AMM SDK Updates #359
Merged
AMM SDK Updates #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
September 8, 2021 15:16
xdrgen -o src/main/java/org/stellar/sdk/xdr --language=java -n org.stellar.sdk.xdr xdr/Stellar-*
tamirms
reviewed
Sep 17, 2021
src/main/java/org/stellar/sdk/LiquidityPoolConstantProductParameters.java
Outdated
Show resolved
Hide resolved
tamirms
reviewed
Sep 17, 2021
src/main/java/org/stellar/sdk/LiquidityPoolConstantProductParameters.java
Show resolved
Hide resolved
tamirms
reviewed
Sep 17, 2021
| @@ -32,6 +32,13 @@ public static Asset create(String type, String code, String issuer) { | |||
| } | |||
| } | |||
|
|
|||
| public static Asset create(ChangeTrustAsset.Wrapper wrapped) { | |||
There was a problem hiding this comment.
I'm not sure if these methods are useful because calling wrapped.getAsset() is just as easy as calling Asset.create(wrapped)
There was a problem hiding this comment.
Yeah, my thinking was that the conversions would be more symmetric this way. e.g. ChangeTrustAsset.create(native), or Asset.create(changeTrustAsset)
tamirms
reviewed
Sep 17, 2021
src/main/java/org/stellar/sdk/LiquidityPoolDepositOperation.java
Outdated
Show resolved
Hide resolved
tamirms
reviewed
Sep 20, 2021
src/main/java/org/stellar/sdk/responses/LiquidityPoolResponse.java
Outdated
Show resolved
Hide resolved
tamirms
reviewed
Sep 20, 2021
tamirms
reviewed
Sep 20, 2021
src/main/java/org/stellar/sdk/responses/effects/LiquidityPool.java
Outdated
Show resolved
Hide resolved
tamirms
reviewed
Sep 20, 2021
tamirms
approved these changes
Sep 21, 2021
Kirbyrawr
reviewed
Sep 21, 2021
| * @see org.stellar.sdk.Server#effects() | ||
| */ | ||
| public class LiquidityPoolTradeEffectResponse extends EffectResponse { | ||
| @SerializedName("liquidity_pool") |
There was a problem hiding this comment.
Shouldn't this be "liquidity_pool_id" ?
There was a problem hiding this comment.
@Kirbyrawr the field should be liquidity_pool but the type of the field is wrong. the fix is here #363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357
This adds the new functionality and updates for AMMs, into the java sdk.
I'm definitely not a Java expert, so feedback here would be great.
Stuff I'm not sure about:
Optional.absentvsnullfor missing fields. In other fields we've usednull, butOptional.absentseems cleaner? Not sure what the convention is here.Idinstances toID?hashCodeon everything?toStringon everything?ChangeTrustAssetandTrustLineAssetbe sortable?