Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asset compare to when asset code are equals #424

Merged
merged 1 commit into from
May 3, 2022
Merged

Fix asset compare to when asset code are equals #424

merged 1 commit into from
May 3, 2022

Conversation

vinamogit
Copy link
Contributor

Fix #381

sreuland
sreuland approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for taking the time to contribute!

@sreuland
Copy link
Contributor

sreuland commented May 3, 2022

@vinamogit , for the PR to merge, the commits need to be signed with GPG key associated to your GH account, any chance you can take a look, I think you can apply signature to existing commits, I haven't done that before, but seeing chats refer to it being possible approaches here

@sreuland sreuland merged commit 45a155d into lightsail-network:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreuland sreuland sreuland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compareTo for Asset is broken for assets that have the same code
2 participants
@vinamogit @sreuland