Include new Protocol 19 Preconditions on Transaction API resource #428
Conversation
…N for Transaction Response
| @SerializedName("min_account_sequence") | ||
| long minAccountSequence; |
There was a problem hiding this comment.
There is a distinction between when minAccountSequence is set or not, so you can't treat not set to a default value like 0. Not set means one-less than the tx seq, but 0 means 0. @Shaptic This may be an issue in Horizon's API and in other SDKs.
There was a problem hiding this comment.
See related conversation: https://discord.com/channels/897514728459468821/971454936615358485/971454986988957736
There was a problem hiding this comment.
ah, ok, thanks for mentioning this, I updated the sdk here to model that as a nullable object to signal if wasn't present in the json.
There was a problem hiding this comment.
It's a pointer in the API, so we're good
… for not set/present
Yes, those have been added as nullable: |
Update the Transaction API Response model to include new P19 Preconditions, this also supports the latest changes in Horizon API to Preconditions json model of datetime attribs being expressed in unix epoch.