Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies & Remove unnecessary dependencies. #523

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

overcat
Copy link
Member

@overcat overcat commented Sep 11, 2023

Part of #496

Remove:

  • commons-io:commons-io
  • org.threeten:threetenbp
  • javax.xml.bind:jaxb-api (test dep)

Update:

  • com.google.code.gson:gson (2.9.0 -> 2.10.1)
  • com.squareup.okhttp3:okhttp (4.10.0 -> 4.11.0)
  • com.squareup.okhttp3:okhttp-sse (4.10.0 -> 4.11.0)
  • com.google.guava:guava (26.0-android -> 32.1.2-android)
  • org.mockito:mockito-core (4.6.1 -> 5.5.0) (test dep)
  • com.squareup.okhttp3:mockwebserver (4.10.0 -> 4.11.0) (test dep)
  • junit:junit (4.12.1 -> 4.13.2) (test dep)
  • org.junit.vintage:junit-vintage-engine (4.12.1 -> 5.10.0) (test dep)

@overcat overcat marked this pull request as ready for review September 11, 2023 03:37
implementation 'com.google.guava:guava:26.0-android'
implementation 'com.google.code.gson:gson:2.9.0'
implementation 'commons-io:commons-io:2.11.0'
// TODO: Do we really need to introduce guava?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you're willing to try removal as part of this pr, and see how much turns red, it brings in com.google.common.base which is ref'd everywhere in app code for Preconditions and Objects convenience helpers, doesn't look like it's required though as a transitive dep from other dependencies.

Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good step in cleanup, left one comment about guava removal if you think it's worthwhile here or later.

@sreuland
Copy link
Contributor

looks like a good step in cleanup, left one comment about guava removal if you think it's worthwhile here or later.

just saw the notice of draft pr on guava removal, ah, I just saw the notice for draft pr on this - #524 (comment)

so, scope of this pr is fine as-is, thanks!

@overcat
Copy link
Member Author

overcat commented Sep 11, 2023

I think we can merge this PR now

@sreuland sreuland merged commit 9d21b19 into lightsail-network:soroban Sep 11, 2023
7 checks passed
@overcat overcat deleted the bump-deps branch September 13, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants