Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: StrKeyException has been removed, use `IllegalArgumentEx… #663

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

overcat
Copy link
Member

@overcat overcat commented Nov 14, 2024

…ception` instead

@overcat overcat merged commit ae48e08 into master Nov 14, 2024
2 checks passed
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 78.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (b9823f6) to head (aefbb28).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/stellar/sdk/StrKey.java 77.35% 12 Missing ⚠️
src/main/java/org/stellar/sdk/KeyPair.java 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #663      +/-   ##
============================================
+ Coverage     80.90%   80.96%   +0.05%     
+ Complexity     1172     1171       -1     
============================================
  Files           203      202       -1     
  Lines          4436     4439       +3     
  Branches        370      370              
============================================
+ Hits           3589     3594       +5     
+ Misses          617      615       -2     
  Partials        230      230              
Files with missing lines Coverage Δ
...tellar/sdk/exception/AccountNotFoundException.java 100.00% <ø> (ø)
src/main/java/org/stellar/sdk/KeyPair.java 83.80% <85.71%> (+0.31%) ⬆️
src/main/java/org/stellar/sdk/StrKey.java 90.90% <77.35%> (-0.68%) ⬇️

@overcat overcat deleted the remove-strkey-exception branch November 14, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant