Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js-stellar-sdk: Smart Contracts: Support new txn types, events, and contract calls #787

Closed
4 tasks done
paulbellamy opened this issue Jul 15, 2022 · 6 comments
Closed
4 tasks done
Assignees

Comments

@paulbellamy
Copy link
Contributor

paulbellamy commented Jul 15, 2022

Once either https://github.com/stellar/stellar-protocol/blob/master/core/cap-0050.md or https://github.com/stellar/stellar-protocol/blob/master/core/cap-0052.md lands. Let's go with @jonjove's option below for now and change it again when the caps finalize.

TODO

  • Support new txn envelope or operation (see caps)
  • Support calling contract RPC endpoints
  • Support parsing new SCVal types and events.
  • Update the docs (Filed an issue on js-soroban-sdk repo for this)
@paulbellamy paulbellamy changed the title Smart Contracts: Support new txn types, events, and contract calls js-stellar-sdk: Smart Contracts: Support new txn types, events, and contract calls Jul 15, 2022
@jonjove
Copy link

jonjove commented Aug 2, 2022

A prototype operation can be found here https://github.com/stellar/rs-stellar-xdr/blob/main/xdr/next/Stellar-transaction.x#L69 with the additional restriction that if you use this it must be the only operation in the transaction (not the only kind of operation, the only operation as in there must be exactly 1). This is almost sure to change in the future, but it should be an acceptable starting point.

@paulbellamy
Copy link
Contributor Author

Goal for this stage is something we could use for the end-to-end example dapp https://github.com/stellar/jump-cannon-deliverables/issues/18 for now.

@paulbellamy
Copy link
Contributor Author

XDR Updates are in stellar/js-stellar-base#538

@paulbellamy
Copy link
Contributor Author

paulbellamy commented Aug 29, 2022

These are done in the soroban branches of js-stellar-base and js-stellar-sdk. Maybe that is good enough for now? Will the npm release process even let us do better than that? < cc @Shaptic

@smac711
Copy link

smac711 commented Sep 13, 2022

@paulbellamy should the priority and iteration for this issue be updated? I see we have decided as noted above this will go with @jonjove 's option and we will fix it later when the CAPs are finalized.

@Shaptic
Copy link
Contributor

Shaptic commented Sep 13, 2022

@paulbellamy just saw this - you could set a tag before publishing (off the top of my head, the syntax is something like yarn publish --tag=<x>), e.g. we used a beta tag (see the Versions tab under stellar-sdk) when we were working on the AMM release (iirc). You could have a soroban tag for yours. But you'd also need to tweak the CI/CD script to look at those branches for the release, as well.

@paulbellamy paulbellamy self-assigned this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants