Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update all requests to RPC to send parameters as an object #923

Closed
mollykarcher opened this issue Feb 13, 2024 · 0 comments
Closed

update all requests to RPC to send parameters as an object #923

mollykarcher opened this issue Feb 13, 2024 · 0 comments
Assignees
@Shaptic
Labels
cdp-horizon-scrum
Milestone
Sprint 44

Comments

@mollykarcher
Copy link

mollykarcher commented Feb 13, 2024 •
edited
Loading

What problem does your feature solve?

We plan to deprecate/remove the ability to send array formatted request parameters to the RPC endpoints. See conversation here stellar/stellar-rpc#13

What would you like to see?

The SDK formats all requests as objects, to avoid any issues when the RPC stops accepting array-based parameters. We'll also need to communicate this change to all external SDK developers.
@mollykarcher mollykarcher transferred this issue from stellar/go Feb 13, 2024
@Shaptic Shaptic mentioned this issue Feb 13, 2024
Merged
@Shaptic Shaptic moved this from Current Sprint to In Progress in Platform Scrum Feb 13, 2024
@Shaptic Shaptic moved this from In Progress to Needs Review in Platform Scrum Feb 13, 2024
@Shaptic Shaptic added this to the Soroban Pubnet Release milestone Feb 13, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shaptic Shaptic

Labels
cdp-horizon-scrum
Projects
Platform Scrum
Status: Done
Milestone
Sprint 44
Development

No branches or pull requests
2 participants
@Shaptic @mollykarcher