Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change XDR to avoid need for ScVal::Object(Option<ScObject>) #133

Open
jonjove opened this issue Aug 5, 2022 · 3 comments
Open

Change XDR to avoid need for ScVal::Object(Option<ScObject>) #133

jonjove opened this issue Aug 5, 2022 · 3 comments

Comments

@jonjove
Copy link
Contributor

jonjove commented Aug 5, 2022

Blocked by xdrpp/xdrpp#34
@leighmcculloch
Copy link
Member

More details available at stellar/stellar-core#3442.

@leighmcculloch
Copy link
Member

leighmcculloch commented Aug 5, 2022 •
edited
Loading

I don't think there is anything to do in rs-stellar-xdr. Xdrgen already supports for Rust generated code cyclic references that occur within a union and don't require the additional optional data union. Once the * is removed from the .x files the Option<> will disappear from this lib. So I think we can close this and track the issue in xdrpp/xdrpp#34 or stellar/stellar-core#3442.

@graydon
Copy link
Contributor

graydon commented Sep 13, 2022

moving off critical path -- this is something to decide and do before we finalize but not before, and it is (perhaps astonishingly) currently blocked by a long chain of dependencies including "upgrading core to C++20"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graydon @leighmcculloch @jonjove and others