Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite liqpool contract #246

Open
leighmcculloch opened this issue May 16, 2023 · 0 comments
Open

Rewrite liqpool contract #246

leighmcculloch opened this issue May 16, 2023 · 0 comments

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented May 16, 2023

The liqpool contract uses strict-receive semantics. It requires the user performing a swap to specify an exact amount to receive, and then takes up to a maximum amount to fulfill it.

We should rewrite the liqpool contract such that it uses strict-send semantics. i.e. The user performing a swap chooses the amount to send in and gets a variable amount out inside a range defined by the user.

Why: Strict-send is more common in AMMs. It's also easier to code for since there isn't a undetermined transfer amount to move out of the users wallet.

Related conversation is at: https://discord.com/channels/897514728459468821/1108150361136566322

@janewang janewang added this to DevX Oct 8, 2024
@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Oct 8, 2024
@janewang janewang moved this from Backlog (Not Ready) to Todo (Ready for Dev) in DevX Oct 8, 2024
@janewang janewang removed this from DevX Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@leighmcculloch and others