-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soroban-cli: Warn or Error When Deploying Contracts Compiled with RC Version of Soroban SDK #1061
Conversation
I've been wanting to remove installing from the deploy command. However, regardless you need to add this check to the install command since the goal is that no incompatible contract should be installed. So you'll need to add the new |
Thanks for taking a look! I moved the logic to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…Version of Soroban SDK (stellar#1061) * Check if contract is compiled using RC SDK version in deploy * Rust fmt * Add info for --ignore-check * Regenerate docs * Update CLI tests * Move rc checking logic to install cmd * Update tests that use install cmd * Formatting fix * Gen docs * rustfmt * Reference fix
…Version of Soroban SDK (stellar#1061) * Check if contract is compiled using RC SDK version in deploy * Rust fmt * Add info for --ignore-check * Regenerate docs * Update CLI tests * Move rc checking logic to install cmd * Update tests that use install cmd * Formatting fix * Gen docs * rustfmt * Reference fix
…Version of Soroban SDK (#1061) * Check if contract is compiled using RC SDK version in deploy * Rust fmt * Add info for --ignore-check * Regenerate docs * Update CLI tests * Move rc checking logic to install cmd * Update tests that use install cmd * Formatting fix * Gen docs * rustfmt * Reference fix (cherry picked from commit c791a68)
What
This PR adds a check to the
soroban contract deploy
command if the Rust SDK version used to compile it is a release candidate SDK version.If the new flag
--ignore-checks
is present, a warning is displayed. Otherwise, the command will return an error.Why
Release candidate versions of the Soroban Rust SDK are not suitable for use with the Stellar Public Network. We should at the very least warn users if they are deploying contracts compiled with release candidate SDK versions.
Closes #941