-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update to use the newest XDR defitinions #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far!
001b48e
to
d95cdd4
Compare
The last failing test is when trying to return a complex enum that includes a case with a tuple including a tuple struct. To see the failing test pull the latest and run
You should get:
A new method was added to highlight this error: pub fn complex_tuple(_env: Env) -> ComplexEnum {
ComplexEnum::Tuple(TupleStruct(
Test {
a: 1,
b: true,
c: Symbol::short("test"),
},
SimpleEnum::First,
))
} At first I thought this was a bug in the enum parsing on my end, but this is the value that is returned from the call. Note: you need to rebuild the examples with |
@willemneal apologies, a bit of a hard landing of a lot of new code and this was obviously a broken path we just didn't have a test for. fix is in stellar/rs-soroban-env#726 which should merge shortly. |
5fe1ced
to
253b362
Compare
Removed unneeded test wasm methods.
@paulbellamy Currently this depends on stellar/rs-soroban-sdk#886 so it shouldn't merge until then, and I'm getting some errors in CI because it currently depends on AhaLab's branch. |
(changed base back-and-forth so github would stop showing a diff that was already in the base branch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing test cases, and sdk bug aside, LGTM.
@@ -77,8 +71,8 @@ impl Contract { | |||
complex | |||
} | |||
|
|||
pub fn address(_env: Env, address: Address) -> Address { | |||
address | |||
pub fn addresse(_env: Env, addresse: Address) -> Address { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope an update from the sdk added a new implicit address
method. Should I add a comment?
I forgot this was pointing at a different branch. I guess we have less stress merging it. Then we could have another PR to add the tests and then merge to main? Or should we just change the branch to main now? |
Yeah, let's do it. So long as we don't forget the fixes. |
* feat: Update to use the newest XDR defitinions (#494) * fix: add back type def parsing for return val * fix: switch to eprintln * chore: narrowed down failing case * fix: update to env fix * chore: clean up test wasm Removed unneeded test wasm methods. * chore: remove unneeded comment * fix: removed unneeded unknown error * fix(cli): symbol (#522) * Fix simulate-transaction test expected xdr. But that will depend on go xdr updates * Update go.mod from stellar/go#4814 * Forgot go.sum --------- Co-authored-by: Willem Wyndham <willem@ahalabs.dev>
What
Use newest XDR.
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
N/A
Issues