Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: Audit and enforce timeouts everywhere we need them #509

Closed
paulbellamy opened this issue Mar 10, 2023 · 2 comments
Closed

soroban-rpc: Audit and enforce timeouts everywhere we need them #509

paulbellamy opened this issue Mar 10, 2023 · 2 comments

Comments

@paulbellamy
Copy link
Contributor

paulbellamy commented Mar 10, 2023

What problem does your feature solve?

At the moment our timeouts (if we have them) are set pretty ad-hoc.

What would you like to see?

We should go through the code, and figure out where we have existing timeouts, and where we should add new timeouts. Then do it. We should also consider adding configuration options for any timeouts that make sense.

Examples:

  • http req/resp
  • different parts of the startup
  • when filling the db
  • db queries
  • core txsub sending
  • (any other external service calls?)

What alternatives are there?

@mollykarcher mollykarcher moved this from Backlog to Next Sprint Proposal in Platform Scrum Mar 22, 2023
@sreuland sreuland moved this from Next Sprint Proposal to Current Sprint in Platform Scrum Mar 28, 2023
@sreuland sreuland moved this from Current Sprint to Next Sprint Proposal in Platform Scrum Mar 28, 2023
@mollykarcher mollykarcher moved this from Next Sprint Proposal to Current Sprint in Platform Scrum Apr 25, 2023
@mollykarcher mollykarcher moved this from Current Sprint to Backlog in Platform Scrum May 24, 2023
@tsachiherman tsachiherman moved this from Backlog to Next Sprint Proposal in Platform Scrum Jun 5, 2023
@tsachiherman tsachiherman moved this from Next Sprint Proposal to Backlog in Platform Scrum Jun 6, 2023
@2opremio 2opremio added this to the Soroban Pubnet Release milestone Oct 5, 2023
@sreuland
Copy link
Contributor

sreuland commented Oct 5, 2023

@tsachiherman , it looks like some areas may be checked off based on prior work you've merged like rpc timeouts with DurationLimiter in #804 and panic handling in #856

@mollykarcher mollykarcher moved this from Backlog to Next Sprint Proposal in Platform Scrum Oct 10, 2023
@mollykarcher mollykarcher moved this from Next Sprint Proposal to Current Sprint in Platform Scrum Oct 10, 2023
@stellarsaur stellarsaur self-assigned this Nov 24, 2023
@stellarsaur stellarsaur moved this from Current Sprint to In Progress in Platform Scrum Nov 27, 2023
@stellarsaur
Copy link
Contributor

After taking a look, we currently have timeouts for:

Adding timeouts for history archive HTTP connections were considered, but decided not to be needed (see stellar/go#1829 for context).

Therefore, everything relevant is covered, so I'm going to close this issue. Feel free to reopen if I missed something.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

6 participants