Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in-memory testing modes #4570

Open
SirTyson opened this issue Dec 10, 2024 · 0 comments
Open

Remove in-memory testing modes #4570

SirTyson opened this issue Dec 10, 2024 · 0 comments
Labels

Comments

@SirTyson
Copy link
Contributor

As of #4562, some tests cases require committing directly to the LedgerTxnRoot via an "in-memory mode" and are not compatible with BucketListDB. Unlike ltx, BucketListDB requires the full ledger close path to update any state. It would be nice to eventually remove this so we could have better test coverage and remove the code overhead from maintaining "in-memory mode." That being said, this is difficult, as many test helper functions assume that arbitrary ledger state can be modified without closing a ledger.

@SirTyson SirTyson added the bug label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant