Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Binary => Bytes #14

Closed
leighmcculloch opened this issue Aug 2, 2022 · 2 comments · Fixed by #16
Closed

Rename Binary => Bytes #14

leighmcculloch opened this issue Aug 2, 2022 · 2 comments · Fixed by #16
Assignees
@leighmcculloch

Comments

@leighmcculloch
Copy link
Member

Rename Binary to Bytes in the Val and Spec XDR

Binary is a somewhat confusing term. When I see it in the docs it doesn't scream at me that this is the type for storing byte slices or byte arrays. Doing a quick survey of Ethereum, they use the term Bytes in both Solidity and Vyper. Thinking back to whenever I have explained Binary to others or in my head, I immediately reach for the term "bytes" or "byte slice".

The term Bytes is what we're using at the SDK layer now since stellar/rs-soroban-sdk#394.
@leighmcculloch leighmcculloch mentioned this issue Aug 2, 2022
Merged
@jonjove
Copy link
Contributor

jonjove commented Aug 10, 2022

Was this resolved by #16?

@leighmcculloch leighmcculloch linked a pull request Aug 10, 2022 that will close this issue
Rename BINARY to BYTES #16
Merged
@leighmcculloch leighmcculloch self-assigned this Aug 10, 2022
@leighmcculloch
Copy link
Member Author

It was! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leighmcculloch leighmcculloch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename BINARY to BYTES stellar/stellar-xdr
2 participants
@leighmcculloch @jonjove