Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaction directionality #3

Closed
jchitpin opened this issue Jan 5, 2022 · 4 comments
Closed

Reaction directionality #3

jchitpin opened this issue Jan 5, 2022 · 4 comments

Comments

@jchitpin
Copy link

jchitpin commented Jan 5, 2022

Is it possible to preserve reaction directionality when plotting metabolic models with escherplot!() using arrows! instead of lines!?

@stelmo
Copy link
Owner

stelmo commented Jan 6, 2022

Hi there,

Yes, that is a good idea! I will implement that this weekend :)

@stelmo
Copy link
Owner

stelmo commented Jan 9, 2022

I just added arrows to the plot. Could you test it out and let me know what you think (v0.5.0)? Note, the arrows are not drawn at the tips of the reaction edges, but slightly further down, I think this looks better (and was substantially easier to implement). If the updated package doesn't work, lmk, Makie just released a new version as well, so there is a small chance that things could go wrong...

@jchitpin
Copy link
Author

Thanks! I'm new to COBREXA so it will take me a bit to figure out where reaction directionality is stored in the model JSON file. Then I'll close off this issue.

@jchitpin
Copy link
Author

jchitpin commented Jan 10, 2022

I forgot to update to (v0.5.0) at first but can confirm the reaction arrows work and look great trailing behind the metabolite nodes. Manually specifying reversibility with reaction_directions also worked as expected. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants