Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, feat: multiple issue to-do list #86

Open
bfahrenfort opened this issue Feb 12, 2024 · 3 comments
Open

fix, feat: multiple issue to-do list #86

bfahrenfort opened this issue Feb 12, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bfahrenfort
Copy link

bfahrenfort commented Feb 12, 2024

Hi, I love the project!

Just wanted to document what I'd like to contribute soon. Each will be a separate PR. Please let me know if any of these are being worked on already or if you have implementation tips/design requirements!

  • Import/export
    • feat: Save volume level as part of the state
    • feat: Sync settings via JSON export
  • UX
    • feat: refactor "Next song" as "Queue" and add "Add to Queue", allow removal from queue as well
      • This one's a lot larger
    • feat: settings: text-match filter out of automatic Queue
      • ex. filter out "1 hour"
    • feat: collapsible callouts with tips on first load
  • CSS
    • style: modify color variables for readability
      • Also a large project
    • fix: text visibility on Player background for some extracted colors
      • If the primary color is close to white, text is unreadable on light mode since it blurs through to the white app background
@stephane-r
Copy link
Owner

Hey @bfahrenfort

Thank you for your todo-list, several points are interesting :)

I can create an issue with a technical part if you wish, for each of the points raised. I have a question regarding import/export, point 1: I'm not sure I completely understood it 😄

Thank you again 👍

@stephane-r stephane-r added enhancement New feature or request good first issue Good for newcomers labels Feb 13, 2024
@bfahrenfort
Copy link
Author

I'll create PRs as I implement them, no need to clutter the repo right now.

As for point 1 of import/export, if you refresh the page after having changed the volume, the volume will go back to 100%. I have very loud headphones so this is uncomfortable every time I open a new session. I want to save it in the same way settings are to persist across refreshes (cookies? Haven't looked at the codebase too deeply yet).

@stephane-r
Copy link
Owner

stephane-r commented Feb 14, 2024

Aaaah yes for volume, good idea. We can add other switch in Settings/Player section.

All settings are save in localStorage by using local "database" with localstoragedb package. You can see this part in src/database folder. You'll need to create new migration for add volume.

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants