-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-ts_proto no longer points to the correct plugin location in version 2.0.0 #1090
Comments
Shoot! Thanks for the report @harrychap , will take a look. I had tried to release 2.0 as an alpha, but it didn't work , and told npm to |
Okay, I pushed out a fix -- @harrychap if you could confirm it works, that would be great! Thank you! |
hmm might be more to it than that actually @stephenh |
😬 sorry guys, as you can tell, I don't have a great project-in-the-wild to actually test these things, and our CI pipeline isn't picking them up. I'll merge #1091 as soon as it passes CI and please do report back! 🙏 🤞 |
It is working for me now |
Thanks for the quick fix! |
Whew! Thanks for confirming @wakingrufus ! Going to close this out, but happy to address any more issues/gotchas. 🤞 |
Noticed when using with gradle like this:
It fails with this path
./node_modules/ts-proto/protoc-gen-ts_proto
Error: Cannot find module './build/plugin'
because build is now './build/src/plugin'
The text was updated successfully, but these errors were encountered: