Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM packages still not working because of protobufjs/minimal #615

Closed
DevSlashRichie opened this issue Jul 14, 2022 · 3 comments · Fixed by #616
Closed

ESM packages still not working because of protobufjs/minimal #615

DevSlashRichie opened this issue Jul 14, 2022 · 3 comments · Fixed by #616
Labels

Comments

@DevSlashRichie
Copy link
Contributor

The package protobufjs/minimal is being import as import * as _m0 from "protobufjs/minimal";
(Produced the following error):

/home/.../WebstormProjects/.../node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:366
    throw new ERR_MODULE_NOT_FOUND(
          ^

And it is required to be imported as follows: import _m0 from "protobufjs/minimal.js";

@paralin
Copy link
Collaborator

paralin commented Jul 14, 2022

background info:

With importSuffix=.js I'm fine with having it also import protobufjs/minimal.js but wonder if there is ever a case where importSuffix would not be .js?

@paralin
Copy link
Collaborator

paralin commented Jul 15, 2022

Good to go in #616 :)

@stephenh
Copy link
Owner

🎉 This issue has been resolved in version 1.117.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants