Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginValidationError with pytest 8.1.0 #50

Closed
hairmare opened this issue Mar 4, 2024 · 5 comments · Fixed by #52
Closed

PluginValidationError with pytest 8.1.0 #50

hairmare opened this issue Mar 4, 2024 · 5 comments · Fixed by #52

Comments

@hairmare
Copy link
Contributor

hairmare commented Mar 4, 2024

The recently released pytest 8.1.0 removed the path argument to pytest_collect_file resulting in this error for plugins that didn't use the new file_path arg.

pluggy._manager.PluginValidationError: Plugin 'flake8' for hook 'pytest_collect_file'
hookimpl definition: pytest_collect_file(file_path, path, parent)
Argument(s) {'path'} are declared in the hookimpl but can not be found in the hookspec

file_path was supported starting with version 7.0.0 of pytest.

@stephrdev
Copy link
Owner

released 4.0.0. Should fix the issues thanks to your PRs. Great!

@hairmare
Copy link
Contributor Author

hairmare commented Mar 5, 2024

Thanks for the quick turnaround!

@hairmare
Copy link
Contributor Author

hairmare commented Mar 5, 2024

btw, 8.1.0 was yanked in the meantime: pytest-dev/pytest#12069

i'm still trying to figure out what this affects, but it looks like 4.0.0 won't be installable until pytest fixes this.

@stephrdev
Copy link
Owner

stephrdev commented Mar 6, 2024

but it should work with pyrest 8.0 until then i think, right?

@hairmare
Copy link
Contributor Author

hairmare commented Mar 6, 2024

as well as with 8.1.0 if you got it before it was yanked 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants