Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralise all the type checking #21

Open
stevan opened this issue Oct 4, 2018 · 1 comment
Open

Centralise all the type checking #21

stevan opened this issue Oct 4, 2018 · 1 comment
Labels
needs improvement Something that needs some improvement question Further information/thought is requested/required
Milestone

Comments

@stevan
Copy link
Owner

stevan commented Oct 4, 2018

There is a ton of type checking spread around all the BUILD methods, they include error messages and other silliness. We can consolidate all these into a Type::Tiny library and then just use that. Should cut down on a lot of duplication, not to mention improve the type checking we currently have.

@stevan stevan added the needs improvement Something that needs some improvement label Oct 4, 2018
@stevan stevan added this to the v0.1.0 milestone Oct 10, 2018
@stevan stevan changed the title Centralise all the type checking into Type::Tiny library Centralise all the type checking Oct 10, 2018
@stevan
Copy link
Owner Author

stevan commented Oct 10, 2018

As mentioned in #15, it is probably a good idea to centralize all this into Graph::QL::Util::Assertions and have that use the Type::Tiny library internally perhaps, or maybe just use Ref::Util directly for most stuff, but support folks using Type::Tiny types as well.

This needs some thinking 🤔

@stevan stevan added the question Further information/thought is requested/required label Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs improvement Something that needs some improvement question Further information/thought is requested/required
Projects
None yet
Development

No branches or pull requests

1 participant