fix(vsg): don't error if XDG_CONFIG_HOME or HOME are not defined #839
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevearc
requested changes
Dec 30, 2025
Owner
stevearc
left a comment
stevearc
left a comment
There was a problem hiding this comment.
I mostly leave the choices of the individual formatter configurations up to the people that actually use them. If you'd like to add a new "global config" directory in a location that makes more sense for Windows, I'm happy to merge it.
On Windows, `XDG_CONFIG_HOME` and `HOME` are not defined by default, which meant that the concatenation turned into `nil .. './config'` resulting in an error. Now `vim.uv.os_homedir()` is used, which should always return a string.
Owner
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows,
XDG_CONFIG_HOMEandHOMEare not defined by default, which meant that the concatenation turned intonil .. './config'resulting in an error.This now checks, if a home directory can be found and only then adds it to the
pathslist. Which means, that with this change, there is no option to have a global config file on Windows (Except for the user defining aHOMEorXDG_CONFIG_HOMEenvironment variable themselves).This could be changed by adding a check to get an env-variable like
USERPROFILEorLOCALAPPDATA.Since vsg does not specify a directory for its config files and the check for one in the home directory is something conform.nvim does on its own, maybe it would be better to decide on a directory on Windows as well and add that. Let me know what you think.