Angular Universal support

[pavankjadda]

Is your feature request related to a problem? Please describe

No

Describe the solution you'd like

Support Angular Universal (SSR)

Describe alternatives you've considered

No

Additional context

No response

[pavankjadda]

@stevermeister Just to summarize from #1

We don't have to store cookies in Node or any other server. We store them in browser as usual but we have to make sure document is available before accessing it. Since we are already injecting document based on Angular docs, the library works as expected

I created sample repo that demonstrates this. It works as expected. Clone the project and run as per instructions in Readme.md file

[pavankjadda]

@stevermeister I found another issue when using this library in SSR. Authentication guards fail when page loads initially because document is not available.

1. When home page loads, home page guard fails as it looks for cookies in ngx cookie service which depends document
2. Then Guard redirects to Login page
3. When document is available, the guard condition passes and redirects back to home page

Even though user goes to original requested page, but he sees redirection to login page, which is not ideal.

I believe this caused by the code where are looking checking isPlatformBrowser not isPlatformServer. I will do some research on this.

[stevermeister]

@pavankjadda no I'm on a business trip and don't have time to dive deep into it. But it's a really interesting topic. Maybe we can even set up a call for next week?

[pavankjadda]

@stevermeister How do you wanna meet? We have Discord server if you like to meet there. Or I can send WebEx link, let me know.

[stevermeister]

@pavankjadda what would be a convenient day/time for you?
I'm new to Discord, not sure what I'm doing wrong, but your link brings me to this message

[pavankjadda]

@pavankjadda what would be a convenient day/time for you?

I'm new to Discord, not sure what I'm doing wrong, but your link brings me to this message

Try this link https://discord.gg/ta8swVRWNF

[stevermeister]

@pavankjadda I had a bit of time to think about it.

I see 2 questions that we need to solve here:

• how to inject cookies
• structure

how to inject cookies

I liked the idea that you suggested: inject cookies via ngExpressEngine.
created simple app here to check - https://github.com/stevermeister/ssr-coookie
From our library, we need to provide InjectionsToken that should be used in express.

structure

The first thought was to create cookie-client, cookie-server separate classes and after factory to create instance by condition.
But then I realized that it's probably an overkill and we only need to patch 2 methods.
What do you think?

[pavankjadda]

I agree with approach. But when it comes to implementation, we need to make sure the service is injected in app.server.module.ts and then modify the request to include cookies. See my reply to your question on Discord

[stevermeister]

created initial PR for it - https://github.com/stevermeister/ngx-cookie-service/pull/171/files

[pavankjadda]

@stevermeister I have a workaround to use current version of the library without any changes. See the StackOverFlow issue for details.

[stevermeister]

@pavankjadda basically, you return TRUE if it's a server-side? :)

[pavankjadda]

@pavankjadda basically, you return TRUE if it's a server-side? :)

Yeah. But it does not work as expected.

[stevermeister]

well, for this case you just skip the auth for the server-side, that is not correct

[martijnmelchers]

@pavankjadda I see the SSR merge has been reverted again, why was this and any idea when it'll be returning?

[pavankjadda]

Yes. It broke existing applications that doesn't use SSR. It will come back soon.