Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Panic for unknown auth type #35

Open
JeremyRubin opened this issue Sep 21, 2022 · 2 comments
Open

Remove Panic for unknown auth type #35

JeremyRubin opened this issue Sep 21, 2022 · 2 comments

Comments

@JeremyRubin
Copy link

_ => unimplemented!(),

Panicking is not a great option here -- we should probably return an error instead.

@sticnarf
Copy link
Owner

The branch is unreachable. All unknown authentication method code will be matched by the m if m != self.auth.id() branch.

We can add a comment here and use unreachable! macro instead.

@JeremyRubin
Copy link
Author

I see!

why not remove the if m != self.auth.id()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants