Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ...error:(NSError**)error methods #162

Closed
stig opened this issue Dec 24, 2012 · 3 comments
Closed

Remove ...error:(NSError**)error methods #162

stig opened this issue Dec 24, 2012 · 3 comments
Labels
Milestone

Comments

@stig
Copy link
Collaborator

stig commented Dec 24, 2012

No description provided.

@stig stig closed this as completed in 62a294f Jan 19, 2013
michaelochs pushed a commit to rockabyte/json-framework that referenced this issue Feb 5, 2013
s2m-updater pushed a commit to SinnerSchraderMobileMirrors/json-framework that referenced this issue Feb 19, 2013
@jmoody
Copy link

jmoody commented Feb 27, 2013

hey stig,

i just pull the latest json-framework into my project and was surprised to see these methods removed. i am not arguing for or against, but i am curious to know why you decided to remove them from the API?

thanks for the framework - i use it extensively.

jjm

@stig
Copy link
Collaborator Author

stig commented Feb 27, 2013

Hi Joshua,

This change is to allow me to focus on what makes this library stand out, which now really is streaming support. It is important to note that the coding master, which you've just pulled, is what will become 4.0. I do not change backward compatibility in minor releases. (Intentionally.)

It is difficult to say how many use that second argument, of course, since I don't instrument the library in any way. But I can say with certainty that nobody who have had a problem and posted on stack overflow showed that they used it in any meaningful way. I think people simply don't understand how to use these error pointers.

And, by the way, now that Objective-C has blocks I think it would be much nicer to provide a block based interface. This also ties in with the idea of an event-based/streaming interface.

Stig

Sent from my iPhone

On 27 Feb 2013, at 13:32, Joshua Moody notifications@github.com wrote:

hey stig,

i just pull the latest json-framework into my project and was surprised to see these methods removed. i am not arguing for or against, but i am curious to know why you decided to remove them from the API?

thanks for the framework - i use it extensively.

jjm


Reply to this email directly or view it on GitHub.

@jmoody
Copy link

jmoody commented Feb 27, 2013

thanks for the detailed explanation.

as i said, the change does not really bother me, but i was curious to know what led you the decision. when implementing my own classes, the question of whether or not to use error pointers is always difficult to answer.

re: blocks - i would certainly use such an interface.

again, thanks for the library. keep up the good work.

ps. to maintain backward compatibility in my own code (where i use the error pointer a great deal), i simply added a category on the parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants