fix: make hscan return flat list of entries
#1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
changed the title
hscan returning keys instead of pairs
silverwind
commented
Aug 8, 2023
silverwind
commented
Aug 8, 2023
silverwind
changed the title
hscan returning keys instead of pairshscan return flat list of entries
silverwind
changed the title
hscan return flat list of entrieshscan return flat list of entries
|
🎉 This PR is included in version 8.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
znewton
added a commit
to microsoft/FluidFramework
that referenced
this pull request
Sep 10, 2024
## Description During peak traffic hours, the RedisCollaborationSessionManager introduced in #22381 could potentially return thousands of sessions. After 1,600 sessions, this exceeds the recommended maximum Redis response size of 200kb (each session+key is about 172 bytes) for optimal efficiency. To improve efficiency, we can use [Redis HSCAN](https://redis.io/docs/latest/commands/hscan/) to fetch sessions from Redis in batches. Here, the default number of sessions per batch is 800 (half the maximum) to allow wiggle room for future session information. ### Tests Added some unit tests for the RedisCollaborationSessionManager, and bumped the `ioredis-mock` version to include stipsan/ioredis-mock#1300.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #962
Ref: https://redis.io/commands/scan/#return-value