Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Smart Disenchanting #34

Open
Torbikini opened this issue Aug 16, 2019 · 5 comments
Open

[Feature request] Smart Disenchanting #34

Torbikini opened this issue Aug 16, 2019 · 5 comments
Labels
feature-request Issue or pull request to add a new feature good first issue Good for newcomers

Comments

@Torbikini
Copy link

Torbikini commented Aug 16, 2019

Is your feature request related to a problem? Please describe.
Could you make the disenchant all champion shards button have options on what to not disenchant?

Describe the solution you'd like
I was thinking a few check boxes or sliders that would let people choose what to disenchant or not to disenchant. The options that I would find most useful would be: do not disenchant if I don't own that champion and do not disenchant if I am not mastery 6 or 7 but are mastery 4 or 5, and disenchant shards for people that are already mastery 7 or 6 but with mastery 6 retain one shard for the upgrade to mastery 7.

Describe alternatives you've considered
Manually doing it.

Additional context
I like using champion shards when going up a tier in mastery since using blue essence seems like a rip off but have a lot of champion shards that are duplicates and/or are for people that I do not own already.

Final Notes
I know this seems like a lot because it is, however, I could see numerous people finding this feature useful. I will look at the source to see if I could implement this however, I'm not sure if I would know enough about the LCU API to do so.

@stirante
Copy link
Owner

stirante commented Aug 16, 2019

I think it's a very good suggestion. Right now we're working very hard on new GUI and new rune sources, so we won't be able to add it very quickly, but I think it's something we should definitely add. I'll try to add it to the next version, but as I mentioned, no idea, when this next version will be ready.

As for implementing it yourself, you can try to do that here https://github.com/stirante/RuneChanger/blob/master/src/main/java/com/stirante/RuneChanger/client/Loot.java#L33
Here is how LolLootPlayerLoot for champion shard looks like: http://files.stirante.com/2019-08-16_13-06-10.txt
For checking champion masteries, first you need to get summonerId (/lol-summoner/v1/current-summoner) and then check all champion masteries (/lol-collections/v1/inventories/{summonerId}/champion-mastery). This will give you something like this: http://files.stirante.com/2019-08-16_13-12-13.txt
But it would require some configuration from GUI as well.

@stirante stirante added feature-request Issue or pull request to add a new feature good first issue Good for newcomers labels Aug 16, 2019
@Torbikini
Copy link
Author

Ok thank you for giving me a starting point. I was trying to do something like this but couldn't figure out how to get started.

@stirante
Copy link
Owner

@Torbikini
Copy link
Author

Sweet! I’ll have to see how you did it and see if I can add any features. I completely forgot about this suggestion until I received an email today.

@stirante
Copy link
Owner

stirante commented Nov 22, 2019

Right now it is implemented as checkbox on/off. When on, it won't disenchant champion shards for not owned champions or for champions where your mastery is between 4 and 6 (for mastery 6 it will leave only one shard). GUI for configuration is planned for next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Issue or pull request to add a new feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants