-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to complete the unit tests for JSONPointer #590
Comments
I'd like to be assigned on this issue, as part of hacktoberfest, if you can label it, thanks! |
@albertotn usually we don't assign issues on this project. If you submit a pull request we can review and label that. |
@johnjaylward There might be some Hacktoberfest requirements for the project maintainers. Let me read up on it, and get things set up tonight. @albertotn Thanks for the offer, I will get the label added. |
Registered with Hacktoberfest, label added, ready to go! |
This issue is being addressed in #631, please continue discussion there. |
See the discussion about unit tests in #588. The code has been merged, but should not be released until all of the suggested unit tests have been implemented. Unit tests that are mentioned in the comments and already in place should be refactored if they do not clearly show the expected result in the code. For example, this code:
Could be refactored to:
The text was updated successfully, but these errors were encountered: