Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub actions for CI #211

Closed
pylipp opened this issue Feb 18, 2021 · 2 comments · Fixed by #221
Closed

Use GitHub actions for CI #211

pylipp opened this issue Feb 18, 2021 · 2 comments · Fixed by #221

Comments

@pylipp
Copy link
Contributor

pylipp commented Feb 18, 2021

Are there any objections against using GitHub actions for CI? It's faster than travis (which queues test suites for quite some time) and a native part of the code hosting platform. Also travis changed it's pricing model last fall, so OS projects have less free build minutes.

With GitHub actions it's straight forward to run both Python tests, and even publish a package automatically to PyPI (not sure if @stlehmann currently manually publishes them?). The config for a side project of mine is here. If desired I'll copy and adjust it for pyads.

@stlehmann
Copy link
Owner

Are there any objections against using GitHub actions for CI?

Actually my only objection is that I know Travis CI well and have been working with it for a long while now. I haven't used github actions so far.

With GitHub actions it's straight forward to run both Python tests, and even publish a package automatically to PyPI (not sure if @stlehmann currently manually publishes them?)

Automatic publishing on PyPi sounds like a nice feature. Indeed I do the upload manually since the beginning of time.

The config for a side project of mine is here. If desired I'll copy and adjust it for pyads.

If you like you can make a PR to setup CI on Github Actions. This way we can run both CIs in parallel and eventually change to Github if it performs better.

@stlehmann
Copy link
Owner

@pylipp Thanks for the bump towards Github Actions. I introduced them with #221. Also Upload to PyPi should happen automatically on release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants