Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong alternate function mappings for GPIO banks #118

Closed
Sh3Rm4n opened this issue Jul 20, 2020 · 1 comment
Closed

Wrong alternate function mappings for GPIO banks #118

Sh3Rm4n opened this issue Jul 20, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Sh3Rm4n
Copy link
Member

Sh3Rm4n commented Jul 20, 2020

As discussed in #116 (comment), the alternate function mapping for the gpios are not 100 % according to the device datasheets (p.43) , in which the alternate function table is listed.

stm32f3xx-hal/src/gpio.rs

Lines 921 to 930 in 2ea16b4

PB0: (pb0, 0, Input<Floating>, moder0, AFRL, afrl0, bs0, br0, odr0, idr0, pupdr0, ot0, [
AF3: (into_af3, af3,),
AF15: (into_af15, af15,),
], [
AF2: (into_af2, af2, ["stm32f302", "stm32f303", "stm32f334", "stm32f328", "stm32f358", "stm32f378", "stm32f398",],),
AF4: (into_af4, af4, ["stm32f303xb", "stm32f303xc", "stm32f303xd", "stm32f303xe", "stm32f358", "stm32f398",],),
AF5: (into_af5, af5, ["stm32f378",],),
AF6: (into_af6, af6, ["stm32f301", "stm32f318", "stm32f302", "stm32f303", "stm32f334", "stm32f328", "stm32f358", "stm32f398",],),
AF10: (into_af10, af10, ["stm32f378",],),
]),

@Sh3Rm4n Sh3Rm4n added the bug Something isn't working label Jul 20, 2020
@teskje
Copy link
Collaborator

teskje commented Sep 27, 2020

With #129 merged, this should be fixed now. I'm closing this issue. If anyone finds specific instances of wrong mappings we can reopen again.

@teskje teskje closed this as completed Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants