Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded-hal 1.0.0-rc.1 #686

Closed
pdgilbert opened this issue Oct 6, 2023 · 6 comments
Closed

embedded-hal 1.0.0-rc.1 #686

pdgilbert opened this issue Oct 6, 2023 · 6 comments

Comments

@pdgilbert
Copy link
Contributor

Any timeline for updating [dependencies.embedded-hal-one] to 1.0.0-rc.1 ? Or is there a branch that already has it?

@tommy-gilligan
Copy link

For anybody interested in looking at this, it appears that the main thing that needs fixing is serial.

@rursprung
Copy link
Contributor

the update to 1.0.0-rc.1 has already been released with 0.18.0.

however, the update to e-h 1.0.0-rc.2 is not yet released (though @burrbull has done it with commit a68a3a1) - it'd be great to get a release with this!

@pdgilbert
Copy link
Contributor Author

Using a recent git version with @burrbull 's commit I am now running several examples with e-h 1.0.0-rc.2 at https://github.com/pdgilbert/rust-integration-testing/actions. See the eh-1-rc2 workflows. The biggest changes were needing to update from rtic v1 to rtic v2 and needing delay traits from DelayNs. Most examples are compiling but note that I have not yet done any hardware testing.

While the hal and my code are using e-h 1.0.0-rc.2, the device crates are all using embedded-hal v0.2.7. The tree is pretty ugly. I hope the quality of this magic dual support in stm32f4xx-hal does not make device crate maintainers lazy and slow to move forward.

@rursprung
Copy link
Contributor

FYI: i've created #715 to update to 1.0.0-rc.3.

I hope the quality of this magic dual support in stm32f4xx-hal does not make device crate maintainers lazy and slow to move forward.

i presume that after 1.0.0 has been released there'll be a period where HALs will support 0.2.x and 1.x in parallel to offer a transition period (without being stuck on an old HAL) while drivers will update to supporting purely 1.x. i hope that this period will be short and that HALs will drop e-h 0.x support soon after (to create some incentive for everyone to really update). theoretically HALs could also immediately drop e-h 0.x support and say "if you need 0.x just stay on the last HAL version supporting it and upgrade once you're ready".

@rursprung
Copy link
Contributor

i think that this issue can be closed as the HAL already implements the latest available e-h version (1.0.0-rc.3 at the moment, which is newer than the requested 1.0.0-rc.1).

i've opened #721 since i noticed that the UART related traits are not yet implemented.

@pdgilbert
Copy link
Contributor Author

Yes, this issue has expired. Looking forward to actual release of eh-1.0.0 very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants