-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ManagedClusterView should preserve original error when retrieving resources #604
Comments
we have different reasons for this condition when failed to get resource: not sure to add a not found reason can help you? |
For the reason
And here is an example of an inaccessible cluster
The line that builds the error message -> see here |
@BenamarMk how about use the statusReason of error to replace |
Problem:
Currently, the
ManagedClusterView
implementation does not preserve the original error when attempting to retrieve resources from aManagedCluster
. Instead, it converts all errors to a generic error and embeds the error text in the condition message (see here), which can be frustrating and difficult to parse.For example, when a resource is
not found
or when there is a connectivity issue, there is nothing that distinguishes between the two cases other than the embedded error message within the.status.condition[0].Message
To address this, we recommend improving the ManagedClusterView implementation to preserve the last error when retrieving resources. Specifically, we suggest adding a new field to the .status object that holds the last error encountered during resource retrieval. Another possibility is to add another condition that holds the error.
The text was updated successfully, but these errors were encountered: