Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Rulesets in GitHub Action #327

Closed
brianmrock opened this issue Jul 6, 2019 · 3 comments
Closed

Custom Rulesets in GitHub Action #327

brianmrock opened this issue Jul 6, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request p/urgent

Comments

@brianmrock
Copy link

brianmrock commented Jul 6, 2019

User Story

As a slightly technical user who is dipping my toe into the world of API Specs, I would like to get feedback in PRs about my specs, and I want that to be as easy as possible, so enabling a GitHub Action and having the whole thing done would be perfect.

Details

We have a GitHub Action: https://github.com/stoplightio/spectral-action which is stuck on Spectral v4. We need to upgrade it to v5.x, improve the README so its obvious how it works, and make it look for spectral rulesets in the root.

We should also document it. I think taking this section:

https://stoplight.io/p/docs/gh/stoplightio/spectral/docs/guides/workflows.md#continuous-integration

and turning it into an "Automation & CI" guide, would mean we can show how it works with CircleCI and GitHub Actions, and folks can use one of those two approaches for inspiration for other CI implementations.

Test out any instructions you write down! 😅

Acceptance Criteria

  • Action is upgraded to support Spectral v5.x
  • Detect .spectral.{json|yml|yaml} in the root folder like the CLI / Studio does
  • A custom ruleset URLs or filepath via SPECTRAL_RULESET variable
  • Add docs to spectral (maybe docs/continuous-integration.md), with a section on GitHub Actions where a user can follow instructions to set it up in a few minutes
  • Release a v1.0.0 of the GitHub Action
  • Add a license (Apache 2.0)

Out of Scope

Custom rules, custom functions, multiple rulesets, etc.

@brianmrock brianmrock added the enhancement New feature or request label Jul 6, 2019
@tbarn tbarn changed the title Spectral : GitHub Action GitHub Action Jul 9, 2019
@philsturgeon philsturgeon added this to the On Deck milestone Jul 15, 2019
@lottamus lottamus removed this from the On Deck milestone Aug 15, 2019
@philsturgeon philsturgeon added this to the Oct '19 milestone Oct 1, 2019
@philsturgeon philsturgeon changed the title GitHub Action Custom Rulesets in GitHub Action Oct 15, 2019
@philsturgeon philsturgeon added the help wanted Extra attention is needed label Dec 27, 2019
@philsturgeon philsturgeon removed this from the Oct '19 milestone Dec 27, 2019
@philsturgeon philsturgeon assigned nulltoken and unassigned XVincentX Dec 27, 2019
@philsturgeon philsturgeon removed the help wanted Extra attention is needed label Jan 2, 2020
@philsturgeon
Copy link
Contributor

@nulltoken I've changed the priority of this one to highest. Can you help us out with this? I set it to medium back in Oct but that meant it got ignored by everyone lol

@philsturgeon
Copy link
Contributor

@nulltoken started a PR on the README, can you take this over. stoplightio/spectral-action#129

@philsturgeon
Copy link
Contributor

This has been done over on the repo! From now on the action and spectral will be much closer to being in sync. Team DevRel on the case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p/urgent
Projects
None yet
Development

No branches or pull requests

5 participants