Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol is always https:// regardless of port in .csv #2

Open
atsoy-sfdc opened this issue Feb 28, 2022 · 1 comment
Open

Protocol is always https:// regardless of port in .csv #2

atsoy-sfdc opened this issue Feb 28, 2022 · 1 comment

Comments

@atsoy-sfdc
Copy link

"https://${target.host}:${target.port}" - protocol http/https should be conditional on port 443 or 80. This way you can skip ${target.port} part

@nkahoang
Copy link
Contributor

@atsoy-sfdc we thought about this.

The idea is that it doesn't matter what protocol that is, plus we can use this to connect to other protocols (i.e. other ports listening on TCP).

It shouldn't matter whether it is HTTP or HTTPS since our purpose is to send traffic. Plus since the site is hosted on github.io which is always HTTPS doing this prevents the browser from stopping making non-https in secure context.

But we're happy to be proven wrong here. Welcome your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants