Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable Signer instance? #8

Open
olizilla opened this issue Dec 5, 2022 · 1 comment
Open

Reusable Signer instance? #8

olizilla opened this issue Dec 5, 2022 · 1 comment

Comments

@olizilla
Copy link
Contributor

olizilla commented Dec 5, 2022

In the constructor a this.datetime is set and it's used to set the value of params.set('X-Amz-Date', this.datetime) which looks like it's something that should match "the datetime the signed url was genearted" from https://docs.aws.amazon.com/general/latest/gr/sigv4-date-handling.html

Is the intention to just create a new signer for every url that needs signing?

@ice-breaker-tg
Copy link
Contributor

Yeah, the datetime should be set on signing not on construction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants