Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate upload/* protocol into w3up #82

Closed
1 of 3 tasks
Gozala opened this issue Oct 3, 2022 · 13 comments
Closed
1 of 3 tasks

feat: integrate upload/* protocol into w3up #82

Gozala opened this issue Oct 3, 2022 · 13 comments
Assignees
Labels
question Further information is requested status/blocked Unable to be worked further until needs are met
Milestone

Comments

@Gozala
Copy link
Contributor

Gozala commented Oct 3, 2022

@Gozala
Copy link
Contributor Author

Gozala commented Oct 3, 2022

Let's try and have demo of this working

@Gozala
Copy link
Contributor Author

Gozala commented Oct 3, 2022

Optionally do the paging

@Gozala
Copy link
Contributor Author

Gozala commented Oct 12, 2022

@jchris @mikeal we need your input in regards to what cli remove should do, which is it either:

  1. Removes entry from the upload list and does not do anything about store list (that is cars in the account).
  2. Removes entry from the upload list and corresponding CARS from the store list.

I personally think it should just remove it from the upload list and maybe have a separate command or a flag to also remove corresponding cars from the store list. However removing cars from the store list can be bit tricky because technically multiple uploads can refer to the same CAR so we may have to remove some and leave the others.

@Gozala
Copy link
Contributor Author

Gozala commented Oct 12, 2022

Linking to the web3-storage/w3up-cli#119 here

@Gozala
Copy link
Contributor Author

Gozala commented Oct 12, 2022

@jchris @mikeal we need your input in regards to what cli remove should do, which is it either:

1. Removes entry from the upload list and does not do anything about `store` list (that is cars in the account).

2. Removes entry from the upload list and corresponding CARS from the store list.

I personally think it should just remove it from the upload list and maybe have a separate command or a flag to also remove corresponding cars from the store list. However removing cars from the store list can be bit tricky because technically multiple uploads can refer to the same CAR so we may have to remove some and leave the others.

Thinking about this a bit more I think we should just not have cli remove and instead have:

  1. cli unlink upload_cid that just removes item form the upload list.
  2. cli delete upload_cid removes cid from both upload list and all linked cars not referenced by by other uploads from the store list.

We should have whole another cli store command subgroup for listing / deleting CARs from the account store.

@mikeal
Copy link

mikeal commented Oct 12, 2022

Let’s do separate commands for “list remove” and “upload remove.”

If there’s a feature request for a combined API we can work out the semantics of calling them together.

@ice-breaker-tg
Copy link
Contributor

@Gozala
Copy link
Contributor Author

Gozala commented Oct 12, 2022

Let’s do separate commands for “list remove” and “upload remove.”

I think it's worth considering that cli store remove will not be the same as cli delete because first one expects CAR CID and second expects upload CID. Which is to say it would be convenient to have command to remove the upload and all it's data.

@Gozala
Copy link
Contributor Author

Gozala commented Oct 12, 2022

So for me personally it makes sense to:

  1. Have cli store add/remove/list commands that map directly to capabilities.
  2. Have cli upload add/remove/list commands that map directly to capabilities.
  3. Have cli upload/delete top level commands that may execute multiple capabilities e.g. delete doing both upload/remove and store/remove

Note that user may not have capabilities to delete CARS but have capabilities to remove uploads from list.

@hugomrdias
Copy link
Contributor

are we doing this pre 0.9 ?

@Gozala
Copy link
Contributor Author

Gozala commented Oct 13, 2022

Yeah plan was to get it out last week while you were all in nodeconf, but we did not managed to.

I think @ice-breaker-tg has it almost done & switching it over to 0.9 shouldn’t require much work so I think it’s best to finish and then just update caps to upgrade to 0.9

@hugomrdias hugomrdias modified the milestone: Pre 0.9 Oct 13, 2022
@heyjay44 heyjay44 added this to the w3up phase 1 milestone Dec 5, 2022
@JeffLowe JeffLowe added question Further information is requested status/blocked Unable to be worked further until needs are met labels Dec 12, 2022
@JeffLowe
Copy link

This may be irrelevant since all this now lives in the new w3upload infra

@hugomrdias
Copy link
Contributor

yep, thanks Jeff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested status/blocked Unable to be worked further until needs are met
Projects
None yet
Development

No branches or pull requests

6 participants