Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilt Windows WinMD+DLL library #628

Open
brodycj opened this issue Jan 31, 2017 · 2 comments
Open

Prebuilt Windows WinMD+DLL library #628

brodycj opened this issue Jan 31, 2017 · 2 comments

Comments

@brodycj
Copy link

brodycj commented Jan 31, 2017

Prebuilt SQLite3 WinMD+DLL library would make Windows builds much easier and will be needed to support Cordova-sqlite-legacy-build-support and Cordova-evcore-extbuild-free on Windows by PhoneGap Build ref:

This may also help with #563 (Windows 10 Release Build [Store -> Create app packages]).

Unfortunately this will not work with cordova-windows pre 5.0.0 which was recently released and not yet included by Cordova CLI. It may be necessary to add a mechanism to continue with the SQLite3 library build for older cordova-windows versions such as 4.4.1/4.4.2, similar to the solution in #580 (support both VS 2015 and 2017 RC).

@brodycj
Copy link
Author

brodycj commented Jan 31, 2017

To clarify: this plugin will continue to support VS 2015 (with PlatformToolset v140), VS 2017 RC/final (with PlatformToolset v141 and cordova-windows 4.4.1/4.4.2), and future versions of VS 2017 with cordova-windows 5.0.0/+. Similar to the solution in #580 (VS 2015 / VS 2017 support) there would be an engine rule to select a branch as follows:

  • newer cordova-windows: use prebuilt SQLite3 WinMD+DLL
  • cordova-windows 4.4.1/4.4.2: build SQLite3 lib with PlatformTools v141 for VS 2017 RC/final
  • cordova-windows < 4.4.1: build SQLite3 lib with PlatformToolset v140 for VS 2015

Since the latest version of Cordova CLI (6.5.0) comes with cordova-windows 4.4.3 I may not filter it out for the prebuilt SQLite3 WinMD+DLL.

/cc @vladimir-kotikov @mbraude

@brodycj
Copy link
Author

brodycj commented Mar 14, 2017

I will probably not support prebuilt WinMD+DLL in this version within the foreseeable future due to the extra overhead needed to maintain multiple branches along with the engine rule. Prebuilt WinMD+DLL will probably be used for some other versions such as Cordova-sqlcipher-adapter and Cordova-sqlite-evcore-extbuild-free. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant