React 16 Support?

[KamalAman]

I've tried to use smark knobs with react v16, and I cannot get anything to display or show up in the Knobs viewer.

[ndelangen]

Hi @KamalAman,

Do you think you'd be able to debug the problem and open a PR with a fix? 🙇

[KamalAman]

The issue seems to be with docgen being undefined on the button in the Usage example when using React 16.

The following describes the issue.
storybookjs/storybook#1762
storybookjs/babel-plugin-react-docgen#33

Other than the root problem with Doc gen performing some magical parsing, the Usage documentation for addon-smart-knobs does not accurately describe what needs to be done with React 16.

Button needs to be defined in another file than the story, and it needs to be the default export of that file.

[chrisjaure]

I think this may be related to a storybook change. It was working for me fine in 3.2, but once I upgraded to 3.3, the knobs weren't showing anymore.

It seems to be related to the marksyConf check here: https://github.com/storybooks/addon-smart-knobs/blob/6eb5cb767cb4e0fbbfb95b11384bf38df96db3e6/src/index.js#L60

and here: https://github.com/storybooks/addon-smart-knobs/blob/6eb5cb767cb4e0fbbfb95b11384bf38df96db3e6/src/index.js#L86

Once I removed the checks, it started working again.

What use-case are these checks serving?

[chrisjaure]

Ah I see it was added to support using withInfo (which I am), but that addon has change in this commit: storybookjs/storybook@170f3eb#diff-c944184f73b67670ca1f8d8e29108c12

I wonder if this is a separate issue?

[ndelangen]

Released with 3.3.0

[Hypnosphi]

@ndelangen we should raise all the @storybook peerDeps to 3.3

[ndelangen]

Done, and published as 3.3.1 @Hypnosphi