build: storybook-static,still have nuxt inst issue

storybook-vue · Oct 25, 2023 · ac15e16 · ac15e16
1 parent 8f4da17
commit ac15e16
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 11 deletions.
diff --git a/packages/storybook-nuxt-cli/src/add-module.ts b/packages/storybook-nuxt-cli/src/add-module.ts
@@ -2,12 +2,15 @@ import { existsSync } from 'node:fs'
 import fsp from 'node:fs/promises'
 import { relative } from 'node:path'
 import { cwd } from 'node:process'
-import { consola } from 'consola'
+
+// import { consola } from 'consola'
 import c from 'picocolors'
 import { parseModule } from 'magicast'
 import { diffLines } from 'diff'
 import path, { join } from 'pathe'
 
+const consola = console
+
 export async function addModuleToNuxtConfigFile(moduleName, cwd) {
   const nuxtConfig = findNuxtConfig(cwd)
   if (!nuxtConfig) {

diff --git a/packages/storybook-nuxt/playground/components/MyNuxtImage.vue b/packages/storybook-nuxt/playground/components/MyNuxtImage.vue
@@ -1,3 +1,3 @@
 <template>
-  <NuxtImg src="https://raw.githubusercontent.com/nuxt/nuxt/HEAD/.github/assets/banner.png" />
+  <NuxtImg src="https://github-production-user-asset-6210df.s3.amazonaws.com/904724/267021354-0396b16c-be9b-4b0d-83b5-5e35dd8298df.png" />
 </template>
diff --git a/packages/storybook-nuxt/playground/pages/about.vue b/packages/storybook-nuxt/playground/pages/about.vue
@@ -6,9 +6,11 @@ defineProps({
 
 <template>
   <div>
-    About Storybook Nuxt Playground
+    About Storybook Nuxt Playground with Nuxt Image
   </div>
   <div>
     {{ msg }}
   </div>
+  Nuxt Image
+  <MyNuxtImage />
 </template>
diff --git a/packages/storybook-nuxt/playground/pages/index.vue b/packages/storybook-nuxt/playground/pages/index.vue
@@ -7,6 +7,8 @@ defineProps({
 <template>
   <div>
     Home Storybook
+    Nuxt Image
+    <MyNuxtImage />
   </div>
   <div>
     {{ msg }}

diff --git a/packages/storybook-nuxt/src/preset.ts b/packages/storybook-nuxt/src/preset.ts
@@ -47,10 +47,12 @@ async function extendComposables(nuxt: Nuxt) {
 
 async function defineNuxtConfig(baseConfig: Record<string, any>) {
   const { loadNuxt, buildNuxt, addPlugin, extendPages } = await import('@nuxt/kit')
+
   nuxt = await loadNuxt({
     rootDir: baseConfig.root,
     ready: false,
-    dev: false,
+    dev: process.env.NODE_ENV !== 'production',
+
     overrides: {
       ssr: false,
     },
@@ -137,7 +139,7 @@ export const viteFinal: StorybookConfig['viteFinal'] = async (
   const nuxtConfig = await defineNuxtConfig(await getStorybookViteConfig(config, options))
 
   return mergeConfig(nuxtConfig.viteConfig, {
-    build: { rollupOptions: { external: ['vue', 'vue-demi'] } },
+    build: { rollupOptions: { external: process.env.NODE_ENV === 'production' ? [] : ['vue', 'vue-demi'] } },
     define: {
       __NUXT__: JSON.stringify({ config: nuxtConfig.nuxt.options.runtimeConfig }),
     },

diff --git a/packages/storybook-nuxt/src/preview.ts b/packages/storybook-nuxt/src/preview.ts
@@ -1,5 +1,3 @@
-import consola from 'consola'
-
 const vueAppRootContainer = document.createElement('div')
 vueAppRootContainer.id = '__nuxt'
 vueAppRootContainer.setAttribute('hidden', 'true')
@@ -8,12 +6,12 @@ document.body.appendChild(vueAppRootContainer)
 async function nuxtAppEntry() {
   const nuxtApp = () => import(('#app/entry')).then(m => m.default).catch(() => {})
   // i
-  const vueAppPromise = nuxtApp().catch((error) => {
-    consola.error('Error while mounting app:', error)
+  const vueAppPromise = nuxtApp().catch((_error) => {
+    // consola.error('Error while mounting app:', error)
   })
   return vueAppPromise
 }
 
 nuxtAppEntry().then((app) => {
-  consola.info('nuxtAppEntry done', app)
+  // consola.info('nuxtAppEntry done', app)
 })
diff --git a/packages/storybook-nuxt/src/runtime/plugins/storybook.ts b/packages/storybook-nuxt/src/runtime/plugins/storybook.ts
@@ -1,6 +1,7 @@
 import { createNuxtApp, defineNuxtPlugin } from 'nuxt/app'
 import { getContext } from 'unctx'
-import logger from 'consola'
+
+// import logger from 'consola'
 
 import type { App } from 'vue'
 import { createRouter, createWebHistory } from 'vue-router'
@@ -11,6 +12,7 @@ import plugins from '#build/plugins'
 import '#build/css'
 
 const globalWindow = window as any
+const logger = console
 
 export default defineNuxtPlugin({
   name: 'storybook-nuxt-plugin',