Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peerDependencies in v7 #175

Closed
11 tasks
AE1NS opened this issue Nov 14, 2022 · 3 comments
Closed
11 tasks

Update peerDependencies in v7 #175

AE1NS opened this issue Nov 14, 2022 · 3 comments
Assignees

Comments

@AE1NS
Copy link

AE1NS commented Nov 14, 2022

Affected design types

  • figma
  • figspec
  • link
  • image
  • iframe

Describe the bug

Inside /packages/storybook-addon-designs/package.json the storybook peerDependencies are still referenced as v6.

How to reproduce the bug?

Install package with storybook alpha packages.
Some "missing peer" errors occurs when using pnpm install.

Expected behaviour

peerDepenendencies should be raised to storybook 7 to fix the errors.

Environment

  • Chrome / Chromium / Chromium based browsers
  • Firefox
  • macOS Safari
  • iOS Safari
  • Samsung Internet
  • Other

Affected versions

7.0.0-beta.1

Storybook versions

7.0.0-alpha.49

@AE1NS AE1NS added the category: bug Something isn't working label Nov 14, 2022
@pocka pocka removed the category: bug Something isn't working label Nov 22, 2022
@pocka pocka self-assigned this Nov 22, 2022
@pocka pocka closed this as completed in 3789d09 Nov 22, 2022
@pocka
Copy link
Collaborator

pocka commented Nov 22, 2022

v7.0.0-beta.2

@bodograumann
Copy link

Unfortunately the range ^6.4.0 || ^7.0.0 does not include the prerelease versions.
I would have thought we should use ^6.4.0 || >=7.0.0-beta <7.0.0 || ^7.0.0, but it seems that might not work either according the the calculator: https://semver.npmjs.com/
Maybe we could exclude v6 and use >=7.0.0-beta <7.0.0 || ^7.0.0?

@pocka
Copy link
Collaborator

pocka commented Feb 3, 2023

No plan to support unstable releases. Use dependency resolutions if you want suppress warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants