Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma new link is not working anymore #244

Closed
2 of 11 tasks
MChrys opened this issue Jun 23, 2024 · 4 comments
Closed
2 of 11 tasks

Figma new link is not working anymore #244

MChrys opened this issue Jun 23, 2024 · 4 comments
Labels
close: duplicate This issue or pull request already exists

Comments

@MChrys
Copy link

MChrys commented Jun 23, 2024

Affected design types

  • figma
  • figspec
  • link
  • image
  • iframe

Describe the bug

my old component link from figma is still working but now, I tried to update link (add new also in new stoy)
now this is what I get in my story book
image
I'm still using the same browser (chrome)
what is weird is my old link still loading properly but is I'm copy paste the updated link of the same component it is not working .

How to reproduce the bug?

go in figma and get a new link with cmd + L or right click copy and copy link to selection

add it in your story like that :

export const Default: Story = {
  parameters: {
    design: {
      type: 'figma',
      url: 'https://www.figma.com/design/t8x8Z4dRrFG5WjZ2WWVisd/space?node-id=687-19311&t=p3wjagyQydsnxEu0-4',
    },
  },
  args: {},
};

and save and check in your storybook the figma tab in the related story

Expected behaviour

I expected the figma view load properly like before

Environment

  • Chrome / Chromium / Chromium based browsers
  • Firefox
  • macOS Safari
  • iOS Safari
  • Samsung Internet
  • Other

Affected versions

lastest

Storybook versions

lastest

@MChrys MChrys added the category: bug Something isn't working label Jun 23, 2024
@CollinHerber
Copy link

Getting this as well with

Refused to frame 'https://www.figma.com/' because an ancestor violates the following Content Security Policy directive: "frame-ancestors 'self' vscode-webview: vscode-file:".

Logged in the console

@CollinHerber
Copy link

Looks like it may be related to https://github.com/storybookjs/addon-designs/pull/240/files

@MChrys
Copy link
Author

MChrys commented Jun 25, 2024

how would you explain that the old link of the same component is still working ?

@pocka
Copy link
Collaborator

pocka commented Jun 26, 2024

Duplicate of #239

@pocka pocka marked this as a duplicate of #239 Jun 26, 2024
@pocka pocka closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2024
@pocka pocka added close: duplicate This issue or pull request already exists and removed category: bug Something isn't working labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
close: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants