Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The copy button is displayed weirdly #1

Closed
mthuret opened this issue Apr 25, 2017 · 6 comments
Closed

The copy button is displayed weirdly #1

mthuret opened this issue Apr 25, 2017 · 6 comments

Comments

@mthuret
Copy link
Member

mthuret commented Apr 25, 2017

Hi,

I tried to add your nice addon, but the copy button is messing with other addons, see:
image

Maybe it would be better to put it like the action logger does, at the bottom right?

@wcastand
Copy link
Collaborator

Hi,

Thanks for the feedback :)

You're right i totally forgot about other plugins, sorry about that.

I took your advice and put the button at the bottom right like other plugins.
I publish the new version on npm.

I'm waiting for your confirmation before closing this issue :)

@mthuret
Copy link
Member Author

mthuret commented Apr 25, 2017

Indeed, bottom right might not be the best idea :(

If you're using panels on the right, then because of the size of the jsx text, then you need to scroll right.

Putting it at the top left make maybe more sense for this action. What do you think?

I'm sorry about that.

@wcastand
Copy link
Collaborator

I think i have an idea and can put the button in the title of the panel (it accept Component apparently).

I'll do that in the evening :)

@wcastand
Copy link
Collaborator

wcastand commented Apr 25, 2017

So i put the button in the title of the panel and it works fine. Only problem is, storybook doesn't center his title, so mine is centered but other title are not aligned.

I made an issue on storybook and I am working with them on a PR to fix the issue.
storybookjs/storybook#959
storybookjs/storybook#961

@wcastand
Copy link
Collaborator

The PR in storybook as been merged. I don't know when it's going to be publish but it should be good and all titles will be centered now :)

Let me now if you have any problems or questions :)

Can we close this issue ? :)

@wcastand
Copy link
Collaborator

wcastand commented May 9, 2017

@mthuret
I guess the issue is fixed.
If you have any problem, let us know.

And thanks again for the feedback :)

@wcastand wcastand closed this as completed May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants