[Bug] Failed to resolve import "global" with yarn PNP

[Arnagos]

What version of vite are you using?

2.9.8

System info and storybook versions

System:
OS: Windows 10 10.0.22000
CPU: (24) x64 AMD Ryzen 9 3900X 12-Core Processor
Binaries:
Node: 16.13.1 - C:\Program Files\nodejs\node.EXE
Yarn: 3.2.0 - ~\AppData\Roaming\npm\yarn.CMD
npm: 8.6.0 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: Spartan (44.22000.120.0), Chromium (101.0.1210.32)

Describe the Bug

When using storybook and this build with Yarn P'n'P 'global' cannot be found.

Stack trace:
[vite] Internal server error: Failed to resolve import "global" from "..\..\..\..\virtual:\@storybook\builder-vite\setup-addons.js". Does the file exist? Plugin: vite:import-analysis File: /virtual:/@storybook/builder-vite/setup-addons.js 1 | import global from 'global'; | ^ 2 | import createPostMessageChannel from '@storybook/channel-postmessage'; 3 | import createWebSocketChannel from '@storybook/channel-websocket';

Link to Minimal Reproducible Example

Repro

Participation

• I am willing to submit a pull request for this issue.

[IanVS]

Hi, without a reproduction it's hard to say exactly what is happening. But vite does not polyfill node global, so you'll need to either find out which of your dependencies is using global, or polyfill it yourself. One easy way is to create a .storybook/preview-head.html with this content:

<script>
  window.global = window;
</script>

[Arnagos]

According to the stack-trace its the '/virtual:/@storybook/builder-vite/setup-addons.js' file that is importing 'global'.
Is that file not part of builder-vite? builder-vite/virtual-file-names.ts contains the reference to it.

Polyfilling it myself, by adding the HTML file with the script, sadly didn't work.

/Edit: builder-vite/codegen-set-addon-channel.ts contains the code.

[Arnagos]

Note: Everything works fine when using the node-modules nodeLinker. It breaks only when using yarn P'n'P.

[IanVS]

Thanks, if you can provide a minimal reproduction, we can do our best to look into it.

[Arnagos]

Repro: https://github.com/Arnagos/import-global-repro

[IanVS]

This is fixed by #383. Can you please try version 0.1.34? You may hit other problems, though, as detailed in #141