Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add nesting of story tree in React Native #12

Closed
Gongreg opened this issue Jul 20, 2018 · 17 comments
Closed

[Feature request] Add nesting of story tree in React Native #12

Gongreg opened this issue Jul 20, 2018 · 17 comments
Labels
enhancement New feature or request feature request

Comments

@Gongreg
Copy link
Member

Gongreg commented Jul 20, 2018

Work summary

It would help a lot to display story list as a full screen list instead of half screen. Since now the story names are sometimes too long to properly fit the sidebar.

Some people have requested functionality to display a nested tree instead of one level list (#2833). It shouldn't be too difficult to implement (I hope).

The main concern I have is that adding multiple level tree can be a performance issue in RN.

Where to start

You need to setup CRNA example and try to work on App/OnDeviceUI files.

Acceptance criteria

  • Stories displayed in full screen instead of a sidebar.
  • Stories are nested.

Who to contact

You can contact me or anyone from contributors in slack.

@sesm
Copy link

sesm commented Jul 30, 2018

@Gongreg regarding nested stories, did you try to use a / separator in story names? It does the job for me. But alas this feature is not documented.

@Gongreg
Copy link
Member Author

Gongreg commented Aug 2, 2018

Hey @sesm, it does work but it works differently than in browser. What I am thinking about is implementing full tree view just like in the browser.

image

Something like this but inside the simulator view.

@storybookjs storybookjs deleted a comment from stale bot Oct 13, 2018
@storybookjs storybookjs deleted a comment from stale bot Oct 13, 2018
@ndelangen
Copy link
Member

@Gongreg We could decide to do one of these things:

  1. We re-implement the treeview in RN
    We can likely re-use a ton, because of the way I wrote it
    (separating the visual from state)
  2. We write the UI of the treeview in such a way it's renderable in RN
  3. We embed the treeview in a webview in RN and communicate with it over a channel
    We'd re-use the code in it's entirety and complexity is lowest

@Gongreg
Copy link
Member Author

Gongreg commented Oct 18, 2018

@ndelangen I would like to try out web view approach. Lets have a session some time in the future.

@Isakdl
Copy link

Isakdl commented Dec 17, 2018

Any progress on this?

@Gongreg
Copy link
Member Author

Gongreg commented Dec 18, 2018

Hey, there was no progress from my side. @ndelangen, would it be possible to create a bundle with treeview now? Or the new treeview is still WIP?

@lancesnider
Copy link

@Gongreg regarding nested stories, did you try to use a / separator in story names? It does the job for me. But alas this feature is not documented.

It doesn't seem to do anything for me, other than make the name longer. Am I missing something?
Screen Shot 2019-03-18 at 8 07 19 PM

@shilman
Copy link
Member

shilman commented Mar 19, 2019

@lancesnider This feature has not been implemented, which is why the issue is still open

@shilman shilman transferred this issue from storybookjs/storybook Feb 2, 2020
@Gongreg Gongreg added enhancement New feature or request feature request labels Feb 5, 2020
@k-sav
Copy link

k-sav commented Nov 6, 2020

Any progress?

@felixolivares
Copy link

Any updates on this feature ?

@dannyhw
Copy link
Member

dannyhw commented Nov 18, 2021

@felixolivares not been developed yet but all PR's are welcome. Working through issues when I can, this is one that I want to fix in 6.0.

@Katia-Toboleva
Copy link

Hey everyone! Any update on this issue?

@dannyhw
Copy link
Member

dannyhw commented Jun 8, 2022

@Katia-Toboleva I've not had time for it yet but its still on my mind to look at it. My idea for this one was to add it after v6 comes out.

@Katia-Toboleva
Copy link

Hi @dannyhw ! Thanks for an update! Is there any timescale for that?

@dannyhw
Copy link
Member

dannyhw commented Jun 9, 2022

@Katia-Toboleva hey, sorry its really hard to give timelines because it just depends on when I have free time or when others want to contribute.

@Katia-Toboleva
Copy link

Ok, no worries! Thanks for looking after this anyway :)

@dannyhw
Copy link
Member

dannyhw commented Jul 14, 2023

please try the new alpha version 6.5.5-alpha.0 which has an implementation of this

@dannyhw dannyhw closed this as completed Jul 14, 2023
@dannyhw dannyhw moved this from todo to done in React Native Storybook Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request
Projects
Archived in project
Development

No branches or pull requests

10 participants