Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating source maps slow the build significantly, should they be opt-in? #11597

Open
luke-j opened this issue Jul 17, 2020 · 3 comments
Open

Comments

@luke-j
Copy link
Contributor

luke-j commented Jul 17, 2020

Is your feature request related to a problem? Please describe.
I'm looking to optimise the time taken by build-storybook. Simply setting the devtool webpack option to undefined reduces my build times by half.

Describe the solution you'd like
I'd argue the average storybook user would benefit more from faster builds than they would from source maps. Therefore, I think source maps should be an opt-in feature due to the performance gains in not generating them. Obviously this might be controversial, so I'd love to hear any thoughts on this.

Describe alternatives you've considered
N/A

Are you able to assist bring the feature to reality?
Sure!

@luke-j
Copy link
Contributor Author

luke-j commented Jul 17, 2020

Actually, I'm going to have a think on this.

@shilman
Copy link
Member

shilman commented Nov 10, 2020

I ran an experiment on #13058 and found a small improvement. cc @ghengeveld @ndelangen

After setting devtool undefined:

start.time.previewWebpack,8710
start.time.managerRender,10259
start.time.previewRender,10847

Before:

start.time.previewWebpack,9180
start.time.managerRender,10885
start.time.previewRender,11445

@shilman shilman modified the milestones: 6.1 perf, 6.2 perf Nov 24, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 25, 2020
@shilman shilman added the todo label Mar 2, 2021
@stale stale bot removed the inactive label Mar 2, 2021
@shilman shilman modified the milestones: 6.2 perf, 7.0 performance May 20, 2022
@shilman shilman removed the todo label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants