Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vite builder to use framework.options for 7.0 #18059

Closed
shilman opened this issue Apr 26, 2022 · 1 comment
Closed

Fix vite builder to use framework.options for 7.0 #18059

shilman opened this issue Apr 26, 2022 · 1 comment
Labels
bug builder-vite
Milestone
7.0 frameworks

Comments

@shilman
Copy link
Member

shilman commented Apr 26, 2022

We are moving away from reactOptions in main.js.

See https://github.com/storybookjs/storybook/pull/17899/files#diff-3b1bd1ed9ea4952d3d61bc0753eb4afbde88764d59b857115c0306b2147c963eR43
@shilman shilman added this to the 7.0 milestone Apr 26, 2022
@shilman shilman mentioned this issue Apr 26, 2022
Merged
1 task
@shilman shilman modified the milestones: 7.0, 7.0 frameworks Apr 26, 2022
@shilman
Copy link
Member Author

shilman commented Jun 8, 2023

We’re cleaning house! Storybook has changed a lot since this issue was created and we don’t know if it’s still valid. Please open a new issue referencing this one if:

@shilman shilman closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug builder-vite
Projects
None yet
Milestone
7.0 frameworks
Development

No branches or pull requests
1 participant
@shilman