Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Only stories do not work in SB7 with the v6 store. #19126

Closed
tmeasday opened this issue Sep 7, 2022 · 1 comment
Closed

Docs Only stories do not work in SB7 with the v6 store. #19126

tmeasday opened this issue Sep 7, 2022 · 1 comment
Assignees

Comments

@tmeasday
Copy link
Member

tmeasday commented Sep 7, 2022

It seems like the current implementation doesn't support them. The issues are:

  • We don't handle docs only stories in StoryStoreFacade.addStoriesFromExports() currently. We should add a docs entry to the internal story index for each docs only story.

  • SET_STORIES filters out docs entries, in order to be back-compat (I'm not sure if we want to change this).

  • So there would be no way to pass the docs only story over the SET_STORIES event, unless we passed it as a story.

Perhaps this means we should pass them over as story entries rather than docs entries. This breaks the model in other places though (for instance we don't do this for docs page entries in v6, instead we recalculate the entries on the manager side, which is a bit crappy). We might want to rethink that though.

@tmeasday
Copy link
Member Author

tmeasday commented May 3, 2023

We fixed this.

@tmeasday tmeasday closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant