Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add preact-vite framework to v7 #20052

Closed
estherkim opened this issue Dec 1, 2022 · 3 comments
Closed

[Feature Request]: Add preact-vite framework to v7 #20052

estherkim opened this issue Dec 1, 2022 · 3 comments

Comments

@estherkim
Copy link

Is your feature request related to a problem? Please describe

No response

Describe the solution you'd like

I have a project using vite and preact, and would like to install storybook v7. Having the framework preact-vite for v7 would be great!

Describe alternatives you've considered

No response

Are you able to assist to bring the feature to reality?

yes, I can

Additional context

No response

@shilman
Copy link
Member

shilman commented Dec 12, 2022

Thanks for volunteering to help @estherkim. If you're willing to work on this, we'd love to collaborate in the #contributing of the Storybook Discord.

@KrofDrakula
Copy link
Member

@estherkim An implementation is being worked on in #20390. There are no NPM packages published for preact-vite until we get it tested, verified & shipped first.

@shilman
Copy link
Member

shilman commented Dec 28, 2022

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-beta.16 containing PR #20390 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Dec 28, 2022
@github-project-automation github-project-automation bot moved this from Nice to have to Done in Core Team Projects Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants