Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: @storybook/addon-storyshots does not support es module exports #20814

Closed
khelif96 opened this issue Jan 27, 2023 · 1 comment
Closed

Comments

@khelif96
Copy link

Describe the bug

In #9576 @storybook/addon-storyshots was updated to allow importing storybook configs from a main.ts file. But it only supports CommonJS module exports using the module.exports format. It would be great if it could also support ES module exports using export default as that is what is recommended in the docs for a storybook config. https://storybook.js.org/docs/7.0/react/configure/overview
#9576 (comment)

To Reproduce

No response

System

System:
    OS: macOS 12.6.2
    CPU: (10) arm64 Apple M1 Max
  Binaries:
    Node: 19.0.1 - /opt/homebrew/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.19.2 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 109.0.5414.119
    Safari: 16.2
  npmPackages:
    @storybook/addon-actions: 7.0.0-beta.34 => 7.0.0-beta.34 
    @storybook/addon-essentials: 7.0.0-beta.34 => 7.0.0-beta.34 
    @storybook/addon-interactions: 7.0.0-beta.34 => 7.0.0-beta.34 
    @storybook/addon-links: 7.0.0-beta.34 => 7.0.0-beta.34 
    @storybook/addon-storyshots: 7.0.0-beta.34 => 7.0.0-beta.34 
    @storybook/react: 7.0.0-beta.34 => 7.0.0-beta.34 
    @storybook/react-vite: 7.0.0-beta.34 => 7.0.0-beta.34 
    @storybook/testing-library: 0.0.14-next.1 => 0.0.14-next.1

Additional context

No response

@jonniebigodes
Copy link
Contributor

The Storyshots addon is officially deprecated and will be removed in a future release of Storybook. To help with the transition process, we've created a migration guide for the available options and common use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants