Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix framework migration handling #20921

Closed
7 tasks
shilman opened this issue Feb 3, 2023 · 1 comment
Closed
7 tasks

CLI: Fix framework migration handling #20921

shilman opened this issue Feb 3, 2023 · 1 comment

Comments

@shilman
Copy link
Member

shilman commented Feb 3, 2023

Is your feature request related to a problem? Please describe

Currently getStorybookInfo incorrectly returns a renderer as a framework, which is wrong and may cause bugs in various uses

Describe the solution you'd like

  • Remove framework/frameworkPackage from getStorybookInfo
  • Get rid of the 6.5 frameworks migration
  • Update the 7.0 new-frameworks migration to:
    • Deal with an empty framework field since the old migration won't run
    • Deal with an old framework field as it already does
    • Run early in the automigrations list so that later automigrations have access to framework
  • Use csf-tools/ConfigFile to get framework from main.js everywhere

Describe alternatives you've considered

No response

Are you able to assist to bring the feature to reality?

no

Additional context

No response

@shilman
Copy link
Member Author

shilman commented Feb 7, 2023

closing as dupe to #20955

@shilman shilman closed this as completed Feb 7, 2023
@github-project-automation github-project-automation bot moved this from Required for QA to Done in Core Team Projects Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants