Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: @storybook/components has a semver dependency on @storybook/icons which only supports React>=17 #23721

Closed
frode-carlsen opened this issue Aug 4, 2023 · 1 comment · Fixed by storybookjs/icons#16

Comments

@frode-carlsen
Copy link

Describe the bug

@storybook/components 7.2.1 has peerDependencies

"peerDependencies": {
    "react": "^16.8.0 || ^17.0.0 || ^18.0.0",
    "react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0"
  },

but a dependency on @storybook/icons which requires React >=17
This results in conflicting peer dependencies when used in an app with React 16
Since Storybook 7 should support React 16, presumably the peerDependencies in icons must be releaxed/fixed

To Reproduce

npm install in a project utilising React 16.14

System

No response

Additional context

No response

@vanessayuenn
Copy link
Contributor

This should be fixed in the latest version. Please try it out! Feel free to reopen this issue if the problem persists. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants